[4.0] Icon- TO fa ( part 3 )#28075
Conversation
joomla-cms-bot
added
NPM Resource Changed
|
just going to repeat what was said before - some of these changes are creating a dependency on fontawesome in the front end as well as the admin |
ty brian Co-Authored-By: Brian Teeman <brian@teeman.net>
I'm more then open to suggestions, but I think part of it is probably a PLT issue. We have that same dependency on icomoon right now. |
|
IIRC @wilsonge said the dependency was ok in the admin but not in the site
Technically yes but as their code is "icon-file" instead of "fas fa-fw fa-file-0" it is much easier to override the more generic icomoon syntax |
am I actually changing front end icons? |
|
@N6REJ @brianteeman no Font Awesome is not ok for the front end: joomla/40-backend-template#441 (comment) So in short:
|
|
@infograf768 could you please retest with your original configuration? @wilsonge assuming it works for jm, I believe I have it configured now where it will work for all 3rd party extensions & is more flexible. As I stated before if you really want the if's removed I'll revert jgrid & both iconclass.php's to their current 4.0 files. Pretty sure it will break things but........... |
|
It now works for me. |
|
@N6REJ Your conflict fixes look wrong to me because they seem to undo changes done in the 4.0-dev branch recently for the new workflows. Please either make sure you update your branch either to the 4.0-dev branch of the CMS repository, or if you update it to your 4.0-dev branch in your repository then make sure that that one is up to date with the 4.0-dev branch of the CMS. To me it looks as if you have done your conflicts resolution nased on an outdated 4.0-dev branch of your repository. You can verify that in the changes of this PR: It shows for the files where you just have solved the conflicts more than only the changes you want to make. |
|
reverted commit fix to double check things per @richard67 statement |
# Conflicts: # administrator/components/com_workflow/tmpl/stages/default.php # administrator/components/com_workflow/tmpl/transitions/default.php
|
@N6REJ I think it looks better now but still I see something which looks as if it had been removed by the new workflows version and now your PR adds it back here: joomla-cms/administrator/components/com_workflow/tmpl/stages/default.php Lines 133 to 147 in a15d72c |
|
grrrrrr it was supposed to remove it. |
|
Looks ok now regarding being up to date with latest 4.0-dev and conflicts. @Razzo1987 @Quy @jwaisner Could you give it again a test? Thanks in advance. |
# Conflicts: # administrator/components/com_templates/src/View/Template/HtmlView.php
|
@wilsonge Can we get this merged now please? |
# Conflicts: # libraries/src/Button/FeaturedButton.php
Since the merge of joomla#28075 the icon is missing in the toolbar for joomla update ### Before  
Since the merge of #28075 the icon is missing in the toolbar for joomla update ### Before  
Since the merge of joomla#28075 the icon is missing in the toolbar for joomla update ### Before  
17 participants
Pull Request for Issue # .
Summary of Changes
This is the final part of the icon to fa- conversions
converts the remaining instances of icon- to fa- so that we're using fontawesome as core icon class.
mappings are not changed
Testing Instructions
using dev inspector check that new and cancel in toolbar use "fas fa-" and do display icons.
check all modals the same way.
ALL icons should now properly use fas fa-
Expected result
Actual result
Documentation Changes Required
explain how fontawesome is now the defacto iconset for J4+
to mark a icon with the featured color requires adding "featured" to the icon class.
for example,
<i class="fas fa-star"></i>will result in the uncolorized version.<i class="fas fa-star featured"></i>will colorize it with the standard icon-featured colorif the full class name is sent instead of just the icon name like 'star' it will be passed thru. So you could use 'fas fa-cog' or 'icon-cog' and thats what will be used.